-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix Github workflow caches to restore successfully more often #3154
Conversation
e8a1775
to
5778dcd
Compare
5778dcd
to
e16601b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, with comments regarding improvements
60a8167
to
2fedf32
Compare
… errors upon cache restore
e610fde
to
7266d95
Compare
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This PR
/usr/local/share/.cache/go
for the Go cache). This allows us to get cache hits between different jobs as a fallbackterraform
,go
,yarn
andproviderSchema
).restore-keys
for caches of the same type. This allows us to restore e.g. a yarn cache from a different job if there's no cache already for the current job (while the cache might not match 100%, it will still improve the results)YARN_CACHE_FOLDER
which is not necessary, since our cache is in the yarn cache dir alreadyGOCACHE
for jobs that don't require it