Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider-generator): Handle */ in docstrings better, try 3 #3076

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

mutahhir
Copy link
Member

Related issue

Fixes broken release pipeline, and issues with Java version of Google Provider.

Description

While we thought we had eliminated this particular bug from the codebase, we had two parts of the codebase that were vying for the same bug and essentially sabotaging one another. I've removed the older instance of the fix attempt because it doesn't play well with JSII. The new version should be better.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit 4a088bb Aug 14, 2023
129 checks passed
@mutahhir mutahhir deleted the fix/docstrings-google branch August 14, 2023 16:57
@mutahhir mutahhir mentioned this pull request Aug 17, 2023
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants