Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade @inquirer/prompts to resolve #2952 #2977

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix: Upgrade @inquirer/prompts to resolve #2952 #2977

merged 1 commit into from
Jul 3, 2023

Conversation

mutahhir
Copy link
Member

@mutahhir mutahhir commented Jul 3, 2023

Related issue

Fixes #2952

Description

I'm still unsure why @inquirer/confirm version 2.0.1 has the bug where it takes all input as 'yes', but it does. From my local testing, changing the version to almost any other version resolves the issue. The library's code also doesn't give a hint about this, so I'm going to stop digging the 'why' and use the easy way forward with upgrading the library.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@ansgarm ansgarm added this pull request to the merge queue Jul 3, 2023
Merged via the queue into main with commit 56f96e3 Jul 3, 2023
32 checks passed
@ansgarm ansgarm deleted the fix/2952 branch July 3, 2023 08:27
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive prompt for state management on init wont let you select no for TF cloud
3 participants