Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hcl2cdk): parse handling of null providers and aliases #2947

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

vascoalramos
Copy link
Contributor

@vascoalramos vascoalramos commented Jun 15, 2023

Related issue

Fixes #2898

Description

The issue with handling null on hcl2json dependency has already been resolved so it's only needed to update the dependency version being used.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@vascoalramos vascoalramos requested a review from a team as a code owner June 15, 2023 08:41
@vascoalramos vascoalramos requested review from mutahhir and DanielMSchmidt and removed request for a team June 15, 2023 08:41
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 15, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your help!

I'm waiting with merging this for a minute since our 0.17 release is just rolling out of the door, will merge this later today or tomorrow :)

@vascoalramos
Copy link
Contributor Author

Great! Thank you for the feedback. If you need anything please let me know

@DanielMSchmidt DanielMSchmidt added this pull request to the merge queue Jun 15, 2023
Merged via the queue into hashicorp:main with commit e119db8 Jun 15, 2023
19 of 20 checks passed
@mutahhir mutahhir mentioned this pull request Jul 5, 2023
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hcl2json parse: error occurs when trying to convert null key (associated with the null provider) as string
4 participants