Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Specific imports for convert #2946

Merged
merged 23 commits into from
Jun 20, 2023
Merged

feat: Specific imports for convert #2946

merged 23 commits into from
Jun 20, 2023

Conversation

mutahhir
Copy link
Member

@mutahhir mutahhir commented Jun 14, 2023

Related issue

Fixes #2647

Description

This PR adds support for specific imports when using cdktf convert. This has the following benefits. Firstly the code is more idomatic, and what we recommend people to write, rather than doing a default import of entire providers. Secondly, this unlocks code generation that works well with C# which does not have star imports.

This also couples with #2935 that updates the imports to the correct destination path per language

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir added this pull request to the merge queue Jun 20, 2023
Merged via the queue into main with commit f5e73d5 Jun 20, 2023
44 of 45 checks passed
@mutahhir mutahhir deleted the feat/specific-imports branch June 20, 2023 13:21
ansgarm added a commit that referenced this pull request Jun 23, 2023
ansgarm added a commit that referenced this pull request Jun 23, 2023
ansgarm added a commit that referenced this pull request Jun 23, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jun 23, 2023
ansgarm added a commit that referenced this pull request Jun 23, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jun 26, 2023
@mutahhir mutahhir mentioned this pull request Jul 5, 2023
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use specific imports for used resources when converting
3 participants