-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow partial snippet translation #2920
Conversation
fd547d2
to
fd2e379
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
7a07229
to
6fe02c1
Compare
d64ff36
to
c0fa42b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me! Just some comments / questions / leftover todos
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Required attributes not contained in the original HCL will be passed in as options into the constructor. Instead of failing these examples at synth time (leading to another set of issues with JSII-Rosetta not being able to use the correct structs) we deal with these issues ahead of time by adding the required info.
This is a simple example to illustrate:
This gets converted to Typescript as
JSII processes it into this Java code:
And e.g. in Golang its
TODOs
@cdktf/provider-generator
and it could be hard to keep in sync since the information is buried in a parserany
type is used instead of (in the example abovedocker.config.ConfigConfig["data"]
), we would need to test if this improves JSIIs capabilities or makes it worse for some reasonfixes: #2822