Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider-generator): remove duplicates between wrapper classes and interfaces generated from provider schemas #2895

Merged
merged 2 commits into from
May 30, 2023

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented May 30, 2023

Related issue

Fixes #2879

Description

If an attribute is called "list" and it's parent class is accessible via a list both the interface for the attribute and the class for the accessor on the parents parent have the same name. This clash causes JSII to fail

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner May 30, 2023 14:43
@DanielMSchmidt DanielMSchmidt requested review from mutahhir and ansgarm and removed request for a team May 30, 2023 14:43
…d interfaces generated from provider schemas
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdktf get Fails for AWS Provider version 4.67.0
3 participants