Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): Support Computed List<List<primitive>> #2850

Merged
merged 7 commits into from
Jun 1, 2023

Conversation

jsteinich
Copy link
Collaborator

Related issue

Fixes #2841

Description

Adding ListList types to be used for computed nested lists/sets.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@jsteinich jsteinich marked this pull request as ready for review April 30, 2023 18:27
@jsteinich jsteinich requested a review from a team as a code owner April 30, 2023 18:27
@jsteinich jsteinich requested review from mutahhir and ansgarm and removed request for a team April 30, 2023 18:27
Copy link
Member

@mutahhir mutahhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Had a minor nit, but otherwise good to merge.

new TerraformProviderGenerator(code, spec).generateAll();
await code.save(workdir);

// const resourceOutput = fs.readFileSync(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment required for later, or should it be removed?

@DanielMSchmidt DanielMSchmidt enabled auto-merge (rebase) June 1, 2023 09:42
auto-merge was automatically disabled June 1, 2023 12:02

Merge queue setting changed

@DanielMSchmidt DanielMSchmidt merged commit 23481df into hashicorp:main Jun 1, 2023
46 of 47 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'StringListList' does not exist on type .../node_modules/cdktf/lib/index
5 participants