Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): run terraform init in serial so no text file is busy in the cache #2843

Merged
merged 2 commits into from
Apr 27, 2023
Merged

fix(cli): run terraform init in serial so no text file is busy in the cache #2843

merged 2 commits into from
Apr 27, 2023

Conversation

DanielMSchmidt
Copy link
Contributor

Closes #2741

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner April 27, 2023 09:40
@DanielMSchmidt DanielMSchmidt requested review from mutahhir and Maed223 and removed request for a team April 27, 2023 09:40
ansgarm
ansgarm reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is there a way we can test this?

packages/@cdktf/cli-core/src/lib/cdktf-project.ts Show resolved Hide resolved
@DanielMSchmidt
Copy link
Contributor Author

Not that I'm aware of, the tests I could think of were too close to the code to be useful

@DanielMSchmidt DanielMSchmidt merged commit 5823209 into main Apr 27, 2023
@DanielMSchmidt DanielMSchmidt deleted the serialize-tf-init branch April 27, 2023 14:59
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

@Maed223 Maed223 Awaiting requested review from Maed223 Maed223 is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/run-unit/@cdktf/cli-core ci/run-unit/@cdktf/commons ci/run-unit/cdktf-cli size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error "text file busy" : Random conflict on parallel stack execution which use the same provider
3 participants
@DanielMSchmidt @ansgarm @team-tf-cdk