Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hcl2cdk): support variable types and validations #2773

Merged
merged 5 commits into from
Apr 13, 2023
Merged

feat(hcl2cdk): support variable types and validations #2773

merged 5 commits into from
Apr 13, 2023

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Apr 5, 2023 •
edited
Loading

Closes #2423

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner April 5, 2023 13:20
@DanielMSchmidt DanielMSchmidt requested review from mutahhir and ansgarm and removed request for a team April 5, 2023 13:20
ansgarm
ansgarm reviewed Apr 5, 2023
View reviewed changes
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a few very small things 👀

packages/@cdktf/hcl2cdk/lib/types.ts Show resolved Hide resolved
packages/@cdktf/hcl2cdk/test/__snapshots__/variables.test.ts.snap Outdated Show resolved Hide resolved
packages/@cdktf/hcl2cdk/test/expressionToTs.test.ts Outdated Show resolved Hide resolved
packages/@cdktf/hcl2cdk/test/expressionToTs.test.ts Outdated Show resolved Hide resolved
packages/@cdktf/hcl2json/lib/syntax-tree.ts Outdated Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt force-pushed the support-variable-validation-blocks branch from feba1ef to 0cd07b4 Compare April 5, 2023 14:16
@DanielMSchmidt DanielMSchmidt force-pushed the support-variable-validation-blocks branch from 8c3eecf to ae75edc Compare April 6, 2023 12:46
DanielMSchmidt and others added 3 commits April 13, 2023 12:08
@DanielMSchmidt
feat(hcl2cdk): support variable types and validations
09711f2 
Closes #2764
@hashicorp-copywrite @DanielMSchmidt
chore: add required copyright headers
640cda1 
Signed-off-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
@DanielMSchmidt
chore: update snapshots
ea307fa
@DanielMSchmidt DanielMSchmidt force-pushed the support-variable-validation-blocks branch from 2bf036e to ea307fa Compare April 13, 2023 10:08
@DanielMSchmidt DanielMSchmidt merged commit d8cbcbb into main Apr 13, 2023
@DanielMSchmidt DanielMSchmidt deleted the support-variable-validation-blocks branch April 13, 2023 12:16
@mutahhir mutahhir mentioned this pull request Apr 18, 2023
Merged
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/run-unit/@cdktf/hcl2cdk ci/run-unit/@cdktf/hcl2json size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDKTF init fails when importing existing project (convert does not support validation blocks)
3 participants
@DanielMSchmidt @ansgarm @team-tf-cdk