fix(lib): support objects with keys that need escaping like e.g. colons #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
requested review from
DanielMSchmidt and
Maed223
and removed request for
a team
DanielMSchmidt
approved these changes
Feb 24, 2023
|
I guess some more tests needs to be updated? |
ansgarm
force-pushed
the
fix-objects-with-colon-in-keys
branch
from
1c25219
to
b16f026
Compare
ansgarm
added
the
ci/update-snapshots
ansgarm
force-pushed
the
fix-objects-with-colon-in-keys
branch
from
715af37
to
674b631
Compare
github-actions
bot
added
ci/updating-snapshots
github-actions
bot
removed
the
ci/updating-snapshots
ansgarm
added
the
ci/update-snapshots
github-actions
bot
added
ci/updating-snapshots
ansgarm
force-pushed
the
fix-objects-with-colon-in-keys
branch
from
1e0199e
to
a5b699e
Compare
ansgarm
force-pushed
the
fix-objects-with-colon-in-keys
branch
from
a5b699e
to
42646e4
Compare
ansgarm
force-pushed
the
fix-objects-with-colon-in-keys
branch
from
42646e4
to
92ef789
Compare
we will just always wrap all keys in quotes
ansgarm
force-pushed
the
fix-objects-with-colon-in-keys
branch
from
29568ba
to
1ce6d9f
Compare
|
(merged with failing checks, since those currently fail on |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will just always wrap all keys in quotes
Closes #1795