Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Remove @types/node-fetch from dependencies as those take precedence over direct devDependencies on @node/types #2623

Merged
merged 3 commits into from
Feb 9, 2023
Merged

fix(cli): Remove @types/node-fetch from dependencies as those take precedence over direct devDependencies on @node/types #2623

merged 3 commits into from
Feb 9, 2023

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Feb 9, 2023 •
edited
Loading

  • fix(cli): Remove @types/node-fetch from dependencies as those take precence over direct devDependencies on @node/types
  • fix: use override for @types/node in yarn monorepo

If this one works, prefer it over #2621

@ansgarm
fix(cli): Remove @types/node-fetch from dependencies as those take pr…
b9bf2e0 
…ecence over direct devDependencies on @node/types

move @node/types to dependencies for provider generator package, as that one requires it to be installed even if installing the cli in a non-dev mode (e.g. for a global install)
@ansgarm
fix: use override for @types/node in yarn monorepo
ef95870
@ansgarm ansgarm changed the title try simpler fix fix(cli): Remove @types/node-fetch from dependencies as those take precence over direct devDependencies on @node/types Feb 9, 2023
@ansgarm ansgarm mentioned this pull request Feb 9, 2023
Closed
@team-tf-cdk team-tf-cdk added size/s and removed size/xs labels Feb 9, 2023
@ansgarm ansgarm marked this pull request as ready for review February 9, 2023 10:31
@ansgarm ansgarm requested a review from a team as a code owner February 9, 2023 10:31
@ansgarm ansgarm requested review from mutahhir and DanielMSchmidt and removed request for a team February 9, 2023 10:31
@ansgarm ansgarm changed the title fix(cli): Remove @types/node-fetch from dependencies as those take precence over direct devDependencies on @node/types fix(cli): Remove @types/node-fetch from dependencies as those take precedence over direct devDependencies on @node/types Feb 9, 2023
@DanielMSchmidt DanielMSchmidt merged commit 532b616 into main Feb 9, 2023
@DanielMSchmidt DanielMSchmidt deleted the try-simpler-fix branch February 9, 2023 11:32
@DanielMSchmidt DanielMSchmidt mentioned this pull request Feb 9, 2023
Merged
@DanielMSchmidt DanielMSchmidt mentioned this pull request Feb 16, 2023
Merged
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielMSchmidt DanielMSchmidt DanielMSchmidt approved these changes

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/provider-integration ci/run-examples ci/run-integration ci/run-unit/@cdktf/hcl2json ci/run-unit/@cdktf/provider-generator ci/run-unit size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ansgarm @DanielMSchmidt @team-tf-cdk