Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Document node-gyp errors if no precompiled binaries are available and the target system misses a native toolchain #2497

Merged
merged 2 commits into from
Jan 16, 2023
Merged

feat(docs): Document node-gyp errors if no precompiled binaries are available and the target system misses a native toolchain #2497

merged 2 commits into from
Jan 16, 2023

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Jan 16, 2023

No description provided.

@ansgarm ansgarm requested review from mutahhir and Maed223 and removed request for a team January 16, 2023 13:45
@ansgarm ansgarm changed the title feat(docs): Document node-gyp errors if no precompiled binaries are available and the target system misses a native toolchain feat(docs): Document node-gyp errors if no precompiled binaries are available and the target system misses a native toolchain Jan 16, 2023
DanielMSchmidt
DanielMSchmidt approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, can live with or without it being fixed :)

error

website/docs/cdktf/cli-reference/cli-configuration.mdx Outdated Show resolved Hide resolved
@ansgarm ansgarm merged commit bc44c2c into main Jan 16, 2023
@ansgarm ansgarm deleted the document-node-gyp-errors branch January 16, 2023 23:57
@ansgarm ansgarm mentioned this pull request Jan 17, 2023
Merged
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielMSchmidt DanielMSchmidt DanielMSchmidt approved these changes

@mgarrell777 mgarrell777 Awaiting requested review from mgarrell777

@robin-norwood robin-norwood Awaiting requested review from robin-norwood

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

@Maed223 Maed223 Awaiting requested review from Maed223 Maed223 is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ansgarm @DanielMSchmidt @team-tf-cdk