Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: support soft sentinel overrides #2485

Merged
merged 21 commits into from
Jan 26, 2023
Merged

chore: support soft sentinel overrides #2485

merged 21 commits into from
Jan 26, 2023

Conversation

mutahhir
Copy link
Member

fixes: #1764

Bonus: Add more testing to state machine

image

ansgarm
ansgarm reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍 (not approving, as this is still a draft)

packages/@cdktf/cli-core/src/lib/models/deploy-machine.ts Outdated Show resolved Hide resolved
@mutahhir mutahhir force-pushed the chore/support-sentinel-overrides branch from 7f20af3 to a7a86e4 Compare January 16, 2023 08:59
@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@mutahhir mutahhir force-pushed the chore/support-sentinel-overrides branch from 9ad211b to dc31b2a Compare January 18, 2023 14:59
@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@mutahhir mutahhir marked this pull request as ready for review January 19, 2023 15:17
@mutahhir mutahhir requested a review from a team as a code owner January 19, 2023 15:17
@mutahhir mutahhir removed the request for review from a team January 19, 2023 15:17
@mutahhir mutahhir force-pushed the chore/support-sentinel-overrides branch from 4644e0d to 853ec91 Compare January 26, 2023 09:13
@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@mutahhir
Copy link
Member Author

Smoke tests ran locally:

  • Single stack apply
  • Single stack destroy
  • Multi stack apply
  • Multi stack destroy

@mutahhir mutahhir merged commit 6a74269 into main Jan 26, 2023
@mutahhir mutahhir deleted the chore/support-sentinel-overrides branch January 26, 2023 09:40
@mutahhir mutahhir mentioned this pull request Jan 27, 2023
Merged
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

@DanielMSchmidt DanielMSchmidt DanielMSchmidt approved these changes

@Maed223 Maed223 Awaiting requested review from Maed223 Maed223 is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/run-unit/@cdktf/cli-core ci/run-unit/cdktf ci/run-unit/cdktf-cli size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentinel soft-mandatory failure missing from CDKTF CLI
4 participants
@mutahhir @team-tf-cdk @ansgarm @DanielMSchmidt