-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: limit concurrency on releases #2318
Conversation
.github/workflows/release.yml
Outdated
@@ -15,6 +15,10 @@ env: | |||
SENTRY_ORG: hashicorp | |||
SENTRY_PROJECT: cdktf-cli | |||
|
|||
concurrency: | |||
group: release | |||
cancel-in-progress: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this be dangerous? 😅
If something is merged while a release is running? Is there something we can do to safeguard that case other than "don't merge while we release a new version" 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! I looked it up and the default is what we want. TL;DR: no canceling, everything else gets queued, if there is already something queued only the last one gets executed, the rest skipped.
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
No description provided.