Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Go to version 1.18 on windows workflows #2219

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

mutahhir
Copy link
Member

Follow up of: #2214

Upgrades the version of Go in the windows platform integration tests.

@mutahhir mutahhir requested a review from ansgarm October 24, 2022 10:08
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

(Do you know whether our users also need Go >=1.18 now?)

@mutahhir
Copy link
Member Author

Do you know whether our users also need Go >=1.18 now?

If they're using Go 1.16, they'll have to upgrade, but I worry about setting it as a minimum version as a patch release. Should we do that as part of version 0.14 release?

@mutahhir mutahhir merged commit 2978413 into main Oct 24, 2022
@mutahhir mutahhir deleted the chore/fix-go-integ-windows branch October 24, 2022 11:18
@ansgarm
Copy link
Member

ansgarm commented Oct 24, 2022

Yeah, sounds like an 0.14 change 👍
Do you still know which change required that? A JSII upgrade?

@mutahhir
Copy link
Member Author

No, I'm unsure what caused it. Wasn't an upgrade because all PRs were experiencing this.

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants