Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Digital Team Files #2203

Merged
merged 7 commits into from
Oct 25, 2022

Conversation

hashibot-web
Copy link
Contributor

Description

Updates managed website-related files.

  • website/Makefile
  • website/scripts/should-build.sh
  • website/scripts/website-build.sh
  • website/scripts/website-start.sh

Note

This pull request was opened via the Digital team's automation. If you have questions, please tag @hashicorp/web-platform

@ansgarm
Copy link
Member

ansgarm commented Oct 19, 2022

@hashicorp/web-platform are these generated PRs expected to be reviewed manually or can they just be merged if CI passes? If yes, we could check whether we want introduce some automerge label and automation that would merge these PRs if CI is green 😁

@thiskevinwang
Copy link
Contributor

@hashicorp/web-platform are these generated PRs expected to be reviewed manually or can they just be merged if CI passes? If yes, we could check whether we want introduce some automerge label and automation that would merge these PRs if CI is green 😁

@ansgarm I think we still want to manually approve these, at least for the near future. And sometimes we push additional commits to these PRs

@ansgarm
Copy link
Member

ansgarm commented Oct 19, 2022

@thiskevinwang Alright! Thanks for clarifying 👍

@thiskevinwang
Copy link
Contributor

👋 @hashicorp/cdktf, requesting a merge on this if it looks good!

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
@thiskevinwang thiskevinwang restored the mktg-tf-7e81fcbf557cc72e31c79dcd4b8809e7 branch November 30, 2022 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants