-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): Use the npm package's repository field for generating go package name #2145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Stellar PR, @mutahhir 🚀 Loved going through it commit by commit 💪
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Related to the move of our pre-built providers to the
cdktf
github organization.Also fixes #1815
The core intention of the PR is to use some of the information published by projen on the pre-built provider's package.json, especially the 'repository' field, to generate the package module path for Go. This will prevent
cdktf provider add
to be broken as we move the providers to thecdktf
organization.