Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): support using remote execution in Terraform Cloud with up to 500 MB (instead of 10MB) #2108

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Sep 13, 2022

updates the TFC API client which had this limit increased in skorfmann/terraform-cloud#10

Closes #2106

I tested this locally using the dev build of the CLI with a project deploying three lambda functions that are resulting in a large archive that is uploaded to TFC for remote execution (it "failed successfully" without the change 😁).
I don't think it makes sense to add a test that uploads large files to TFC.

…o 500 MB (instead of 10MB)

updates the TFC API client which had this limit increased in skorfmann/terraform-cloud#10
Copy link
Member

@mutahhir mutahhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansgarm ansgarm merged commit 8c6bc66 into main Sep 14, 2022
@ansgarm ansgarm deleted the update-tfc-api-client branch September 14, 2022 09:32
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3BucketObject throws Request body larger than maxBodyLength limit when uploading large objects
2 participants