fix(cli): add major versions greater 1 to package name when installing pre-built providers for go #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g pre-built providers for go Resolves #1998
DanielMSchmidt
approved these changes
Aug 5, 2022
|
Would it be possible to add a test case for this? |
…eturning e.g. v0.12.0 if the users uses Go while returning 0.12.0 for all other languages
ansgarm
force-pushed
the
fix-provider-add-for-go-with-major-version
branch
from
35abd41
to
0d529d6
Compare
ansgarm
force-pushed
the
fix-provider-add-for-go-with-major-version
branch
from
9875b59
to
fc1e93c
Compare
… and might need to be disabled for some time 🤯 and fix "v" prefix still being in test
ansgarm
force-pushed
the
fix-provider-add-for-go-with-major-version
branch
from
fc1e93c
to
6e46d60
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1998