-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): Introduce TerraformDynamicBlock to enable iterator usage on blocks #1882
Conversation
2be1a71
to
ed59fcf
Compare
b5dfe8c
to
56c3cbd
Compare
56c3cbd
to
8dd159c
Compare
d3a3ab4
to
981b87e
Compare
965034f
to
9967d26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great work! Just a couple of comments :)
575f48d
to
b2dfdf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides from the missing docs this looks great 👍
d6c0f4f
to
8c59276
Compare
2efbfaf
to
d1510a3
Compare
d1510a3
to
ab40934
Compare
ab40934
to
c82bc5b
Compare
c82bc5b
to
9ea8258
Compare
Code copied and adjusted from my former (and later closed) PR #1130
adds tests, too.
…eed them anymore as passing a stack is optional now and we don't create cross stack references for iterations and for expressions anyway
…cursion into a recursive datastructure which explodes
also remove outdated comment
…er tests to Go aswell
…ava, Python and C#
9ea8258
to
b29b201
Compare
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Closes #1798
Open tasks
or at least throw an Error if used at an invalid location. Not sure how to detect this yet.terraform validate
to confirm result is valid (might be something to add to edge provider tests)Add docs to iterator docs with an example for block level iteration (in each language)will follow in a separate PR as they will be based on a branch that is not merged yettodo:
comments in the code base