-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Fix package version check on Windows #1831
Conversation
I'd like to have a test for this, but I'm not sure the best spot. The unit tests aren't setup very well for checking this and I'd rather not make an entirely new integration test just for this. |
Hm, I'd be open to both 🤷♂️ If it tests, it tests 😁 |
I'm working on this, as our CI is currently broken 🙃 fyi: I'll commit to your branch, hope that is fine with you @jsteinich :) |
…r now uses the dev version which can change between 0.0.0 or an prerelease one depending on where it runs
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
For at least c#, the package version lookup is failing on Windows due to line endings. I went ahead and change the other languages as well.
I believe this is at least partially contributing to #1816.