Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider-generator): strictly adhere to the provider schema #1792

Merged
merged 1 commit into from
May 12, 2022

Conversation

DanielMSchmidt
Copy link
Contributor

We ignored fields in the past to not expose fields incorrectly, which has been a good approach with the provider generator being work in progress

Now that it's more stable we can leave these guards behind and if issues arise we can try to fix them upstream in the respective providers

Closes #1602

We ignored fields in the past to not expose fields incorrectly, which has been a good approach with the provider generator being work in progress

Now that it's more stable we can leave these guards behind and if issues arise we can try to fix them upstream in the respective providers

Closes #1602
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review May 12, 2022 09:14
@ansgarm ansgarm merged commit d4bb45f into main May 12, 2022
@ansgarm ansgarm deleted the include-id-when-assignable branch May 12, 2022 10:05
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws.vpc.DataAwsVpc cannot be used with VPC id without filtering
2 participants