Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add best practice page #1790

Merged
merged 16 commits into from
May 24, 2022
Merged

chore: add best practice page #1790

merged 16 commits into from
May 24, 2022

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented May 11, 2022

Document best practices, of course there are more, but we can evolve this page over time :)

Closes #974, #399

website/docs/cdktf/concepts/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/concepts/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/concepts/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/concepts/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/concepts/best-practices.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're very close on this - I'm excited! See what you think of these suggestions. Please push back in any cases where my edits misrepresent the meaning :)

website/docs/cdktf/create-and-deploy/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/best-practices.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/best-practices.mdx Outdated Show resolved Hide resolved
Co-authored-by: Laura Pacilio <[email protected]>
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixing a few very minor typos. After you merge these in, please feel free to merge this PR! Great work on this!! I think this is an excellent start at this best practices page that we can iterate on over time!

Co-authored-by: Laura Pacilio <[email protected]>
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs page] CDKTF Best Practices
4 participants