-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(provider-generator): Include Provider Version in Generated Bindings #1586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @jsteinich
1169581
to
13d3dcc
Compare
This does break compatibility in that the new cli will generate binding not compatible with the old cdktf lib since a new metadata property was added. We could just change the meaning of the existing one, but that seems like more of a breaking change. Also having both allows for something like |
@jsteinich could you fix the merge conflict, please? Seems like I can't do this on this PR |
c2a44b4
to
9261edf
Compare
Deployment failed with the following error:
|
f4d50df
to
7901759
Compare
7901759
to
9ad3339
Compare
2d0173f
to
a606c37
Compare
force merging this, as only Vercel fails – ignoring it in the Github action did not work sadly. |
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #684
Fixes #228
Fixes #318
Fixes #43
The exact version of the resolved provider is now recorded as metadata for the generated provider and resources. For the provider, this exact version is used in
required_providers
block to ensure a consistent experience and give users more control over the provider version used.Also omitting version constraints when either is undefined.