-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Model ComplexComputedLists as ComplexLists and ComputedObjects #1499
Conversation
isSingleItem
property from ComplexObjects6b6456b
to
031837b
Compare
Quick update on this PRToday we (@skorfmann, @DanielMSchmidt, @jsteinich and I) had a deeper look into the changes that this PR would introduce. // with ComplexComputedLists (previously)
ImageId: images.Images(jsii.String("0")).Id(),
// with Arrays of ComplexListItems (this PR)
ImageId: cdktf.Token_AsString(cdktf.Fn_Lookup(cdktf.Fn_Element(images.Images, 0), jsii.String("id"), jsii.String("")), &cdktf.EncodingOptions{}), TypeScript is less bad, but still terrible: // with ComplexComputedLists (previously)
imageId: images.images("0").id,
// with Arrays of ComplexListItems (now)
imageId: Token.asString(Fn.lookup(Fn.element(images.images, 0), "id", "")), As this does not makes things simpler (besides allowing to access a whole list directly via e.g. We'd like a solution to still be able to autocomplete the properties on individual items (e.g. Sidenote: Maps probably share a similar problem and we should also address that (separately). |
1c12902
to
48be8c7
Compare
1cc66e6
to
14724b2
Compare
efadec1
to
83f6924
Compare
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hashicorp/terraform-cdk/B1BSvD7YrBKmvQYRfMP2MQhsNmXa [Deployment for 3e579d4 canceled] |
3e36314
to
1126202
Compare
1126202
to
5503189
Compare
5503189
to
d66acd3
Compare
b5e8026
to
3c862bd
Compare
5ca3716
to
880bb91
Compare
880bb91
to
9b66c39
Compare
As ComplexObjects always are single items.
9b66c39
to
0e4a845
Compare
0e4a845
to
65a39cf
Compare
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Closes #993
Open Subtasks