Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): resolve objects correctly in cross stack references #1487

Merged

Conversation

DanielMSchmidt
Copy link
Contributor

Closes #1481

@DanielMSchmidt DanielMSchmidt force-pushed the error-passing-entire-objects-into-cross-stack-references branch 9 times, most recently from ffbe8f7 to d0ea626 Compare January 17, 2022 16:55
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review January 17, 2022 16:57
@DanielMSchmidt DanielMSchmidt force-pushed the error-passing-entire-objects-into-cross-stack-references branch 2 times, most recently from b5d34ad to 45a6a1f Compare January 18, 2022 17:42
packages/cdktf/lib/tfExpression.ts Show resolved Hide resolved
packages/cdktf/test/resource.test.ts Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt force-pushed the error-passing-entire-objects-into-cross-stack-references branch from a9010c3 to 1c7b6ac Compare January 19, 2022 16:28
@DanielMSchmidt DanielMSchmidt merged commit 909ed77 into main Jan 19, 2022
@DanielMSchmidt DanielMSchmidt deleted the error-passing-entire-objects-into-cross-stack-references branch January 19, 2022 17:10
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross Stack References should support or error on passing entire objects
2 participants