Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): Create assets for local modules #1476

Merged
merged 5 commits into from
Jan 13, 2022

Conversation

jsteinich
Copy link
Collaborator

@jsteinich jsteinich commented Jan 11, 2022

Automatically create a TerraformAsset for any local module as specified in #664 (comment) and #948

Closes #946 (Really already fixed)
Supersedes #961

@jsteinich jsteinich marked this pull request as ready for review January 12, 2022 04:47
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nit picks, looks good so far :)

packages/cdktf/test/terraform-hcl-module.test.ts Outdated Show resolved Hide resolved
packages/cdktf/lib/terraform-asset.ts Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect module source path generated for local modules
2 participants