Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): document escape hatch for dynamic blocks #1215

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

Closes #837

Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you some comments to review :-) Please let me know if I misunderstood the context here and I can adjust (wasn't sure if this was related to dynamic blocks or just dynamic values) - thank you for tagging me :-)

Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the clarification! :) I have a few more suggestions. I just want to add some context for users who may not be familiar with dynamic blocks. I also want to make sure it's very clear how the escape hatch is synthesized into a Terraform config - let me know if I got anything wrong, and thank you!

@DanielMSchmidt DanielMSchmidt merged commit d332c5b into main Oct 29, 2021
@DanielMSchmidt DanielMSchmidt deleted the add-dynamic-blocks-example branch October 29, 2021 08:31
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example for how an override works for dynamic blocks to docs
4 participants