Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hcl2cdk): Copy local modules when init from TF project #1024

Merged
merged 9 commits into from
Oct 15, 2021

Conversation

jsteinich
Copy link
Collaborator

@jsteinich jsteinich commented Sep 15, 2021

Fixes #1009

@jsteinich jsteinich marked this pull request as ready for review October 6, 2021 02:44
@skorfmann
Copy link
Contributor

I think this should be tested somehow. Not sure where the best place is, looks like the most relevant test for this behaviour right now is here

describe("convertProject", () => {
it("has a similar plan", async () => {
const { importPath, targetPath } = terraformProject([
[

What do you think?

@jsteinich
Copy link
Collaborator Author

I think this should be tested somehow

I'll work on getting at least a simple test in place.

@skorfmann
Copy link
Contributor

Gonna merge regardless of the windows builds, since we know that's an unrelated issue which is going to be fixed and the builds on this PR were green before.

@skorfmann skorfmann merged commit 8fedcf1 into hashicorp:main Oct 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy local module files when using import from Terraform project
2 participants