-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hcl2cdk): Copy local modules when init from TF project #1024
feat(hcl2cdk): Copy local modules when init from TF project #1024
Conversation
48ae671
to
590e088
Compare
8a96aa1
to
8f89816
Compare
I think this should be tested somehow. Not sure where the best place is, looks like the most relevant test for this behaviour right now is here terraform-cdk/packages/@cdktf/hcl2cdk/test/convertProject.test.ts Lines 153 to 156 in 8faaad4
What do you think? |
I'll work on getting at least a simple test in place. |
Gonna merge regardless of the windows builds, since we know that's an unrelated issue which is going to be fixed and the builds on this PR were green before. |
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #1009