Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use default tagging #183

Merged
merged 15 commits into from
Jun 16, 2021
Merged

use default tagging #183

merged 15 commits into from
Jun 16, 2021

Conversation

anniehedgpeth
Copy link
Contributor

@anniehedgpeth anniehedgpeth commented Jun 11, 2021 •
edited
Loading

Background

A task was done previously that standardizes on tagging across tests (and other repo modules), but the OkToDelete tag was neglected. Also, the change only affected the common_tags variable; it did not ensure that every taggable resource was being tagged. This is being done in this branch for the test suites by adding the default_tags to the AWS provider for the test modules while removing common tags on individual resources. Consequently, it required that I add a separate tag variable for the autoscaling group tags, as explained in the variable description.

Asana Task

How Has This Been Tested

terraform plan was run locally for each test. I will /test all here in the PR.

This PR makes me feel

default

@anniehedgpeth anniehedgpeth requested a review from a team as a code owner June 11, 2021 18:56
@anniehedgpeth
Copy link
Contributor Author

That was a bad choice of gifs, and I am sorry if it gives you a headache. 😳

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 11, 2021 •
edited by github-actions bot
Loading

/test all
💻 @hc-team-tfe

Terraform Public Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 failure

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

💻 @hc-team-tfe

Terraform Private TCP Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 failure

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

💻 @hc-team-tfe

Terraform Private Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 failure

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

@anniehedgpeth anniehedgpeth changed the title Annie use default tagging use default tagging Jun 11, 2021
@anniehedgpeth anniehedgpeth mentioned this pull request Jun 11, 2021
Closed
@anniehedgpeth anniehedgpeth marked this pull request as draft June 11, 2021 22:03
anniehedgpeth added 2 commits June 11, 2021 16:17
remove common_tags
056a110 
in favor of provider default_tags
revert Environment tag
86da558
@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 11, 2021 •
edited by github-actions bot
Loading

/test all
💻 @hc-team-tfe

Terraform Private TCP Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 failure

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

💻 @hc-team-tfe

Terraform Private Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 failure

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

💻 @hc-team-tfe

Terraform Public Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 failure

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 11, 2021 •
edited by github-actions bot
Loading

/test all
💻 @hc-team-tfe

Terraform Private TCP Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 failure

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

💻 @hc-team-tfe

Terraform Private Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

💻 @hc-team-tfe

Terraform Public Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ success

  • Terraform Destroy 🔥 success

🔗 Action Summary Page

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 14, 2021 •
edited by github-actions bot
Loading

/test private-active-active
💻 @hc-team-tfe

Terraform Private Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 14, 2021 •
edited by github-actions bot
Loading

/test private-tcp-active-active
💻 @hc-team-tfe

Terraform Private TCP Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ success

  • Terraform Destroy 🔥 success

🔗 Action Summary Page

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 14, 2021 •
edited by github-actions bot
Loading

/test private-active-active
💻 @hc-team-tfe

Terraform Private Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 15, 2021 •
edited by github-actions bot
Loading

/test all
💻 @hc-team-tfe

Terraform Private TCP Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ success

  • Terraform Destroy 🔥 success

🔗 Action Summary Page

💻 @hc-team-tfe

Terraform Public Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ success

  • Terraform Destroy 🔥 success

🔗 Action Summary Page

💻 @hc-team-tfe

Terraform Private Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 success

🔗 Action Summary Page

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 15, 2021 •
edited by github-actions bot
Loading

/test private-active-active destroy=false
💻 @hc-team-tfe

Terraform Private Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 skipped

🔗 Action Summary Page

aaron-lane
aaron-lane requested changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I identified the source of the latest test failure 👁️‍🗨️

tests/private-active-active/main.tf Outdated Show resolved Hide resolved
@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 16, 2021 •
edited by github-actions bot
Loading

/destroy private-active-active
💻 @hc-team-tfe

Terraform Private Active/Active Destruction Report 📰

  • failure Terraform Destroy 🔥

🔗 Action Summary Page

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 16, 2021 •
edited by github-actions bot
Loading

/destroy private-active-active
💻 @hc-team-tfe

Terraform Private Active/Active Destruction Report 📰

  • success Terraform Initialization ⚙️

  • success Terraform Destroy 🔥

🔗 Action Summary Page

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 16, 2021 •
edited by github-actions bot
Loading

/test all
💻 @hc-team-tfe

Terraform Public Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ success

  • Terraform Destroy 🔥 success

🔗 Action Summary Page

💻 @hc-team-tfe

Terraform Private Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 success

🔗 Action Summary Page

💻 @hc-team-tfe

Terraform Private TCP Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ success

  • Terraform Destroy 🔥 success

🔗 Action Summary Page

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Jun 16, 2021 •
edited by github-actions bot
Loading

/test private-active-active
💻 @hc-team-tfe

Terraform Private Active/Active Test Report 📰

  • Terraform Initialization ⚙️ success

  • Terraform Validation 🔍 success

  • Terraform Apply 📖 success

  • K6 Smoke Test 🏗️ skipped

  • Terraform Destroy 🔥 success

🔗 Action Summary Page

@anniehedgpeth anniehedgpeth marked this pull request as ready for review June 16, 2021 18:13
aaron-lane
aaron-lane approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐛

We'll take care of the latest private-active-active issue separately.

@anniehedgpeth anniehedgpeth merged commit eb9478a into main Jun 16, 2021
@anniehedgpeth anniehedgpeth deleted the annie-use-default-tagging branch June 16, 2021 18:20
@anniehedgpeth anniehedgpeth mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-lane aaron-lane aaron-lane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anniehedgpeth @aaron-lane