Add support for Consul 1.15.x#159
Merged
Merged
Conversation
eikenb
approved these changes
Mar 8, 2023
eikenb
left a comment
eikenb
left a comment
There was a problem hiding this comment.
Looks good.
I'm curious... what templating system are those .tpl files using?
Contributor
Author
The templates are rendered in the module using the Terraform |
kisunji
reviewed
Mar 8, 2023
pglass
approved these changes
Mar 8, 2023
cthain
commented
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This PR adds support for:
consul loginusing the AWS auth method. There is an issue with using theconsul acl token read -selfon Consul 1.15.0, somesh-taskandgateway-taskhave been updated to use the HTTP API instead.consul-ecs net-dialcommand for ECS health checks on thesidecar-proxycontainer.How I've tested this PR:
How I expect reviewers to test this PR:
👀
Checklist: