[Updated] LogCache should not cache on StoreLogs error #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogCache was caching logs and then invoking store.StoreLogs(). However, if StoreLogs() fails to store, LogCache.Get() could still return logs that had not been persisted into storage, which could lead to a node failing to restart with a "log not found" panic. This PR ensures that LogCache only cache logs if StoreLogs was successful. Resolves #429 Signed-off-by: Ivan Kozlovic <[email protected]>
notnoop
approved these changes
Apr 15, 2021
Co-authored-by: Mahmood Ali <[email protected]>
Co-authored-by: Mahmood Ali <[email protected]>
notnoop
reviewed
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original author was #430
[FIXED] LogCache should not cache on StoreLogs error
LogCache was caching logs and then invoking store.StoreLogs().
However, if StoreLogs() fails to store, LogCache.Get() could still
return logs that had not been persisted into storage, which could
lead to a node failing to restart with a "log not found" panic.
This PR ensures that LogCache only cache logs if StoreLogs was
successful.
Resolves #429
Signed-off-by: Ivan Kozlovic [email protected]