Reject leadership transfer requests when in candidate state #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
approved these changes
Jul 21, 2020
|
Do I understand it right if this is a fix for hashicorp/consul#7750? If so, is there a plan for making a new release of raft and upgrading raft in consul/nomad/vault? We currently have a nomad cluster unoperational with the exact symptoms as the consul issue above. UPDATE: Our incident was resolved by upgrading to raft protocol 3 from 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
raft.LeadershipTransfer().Error()is called while raft is in candidate state the caller will block until it transitions to follower or leader. If raft is in an error state and unable to elect a leader this could block indefinitely. This PR causesLeadershipTransfer()called on a candidate node to immediately return an error.