Obtain Configuration before Raft Starts #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for moving this forward :) |
|
Glad to help! :) |
catsby
reviewed
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #298.
Introduces a new function
GetConfigurationwhich allows for bypassing of background goroutines so the configuration can be obtained before Raft starts.Thanks @stapelberg for help. Your PR laid the groundwork for this, and your test code was directly used. Thank you to @RobbieMcKinstry for the direct guidance.
We took a different approach to implementation leaning on the existing
Raft.GetConfiguration()future. @banks suggested using theRecoverClustermethod, however we abandoned this idea due to the complexities of the signature.