Replaced logging with hclog throughout raft. #360
Conversation
This simply replaces the existing logging implementation with hclog to make everything consistent throughout the library.
|
|
|
Hey @elliotcourant , thank you SO much for this. Seriously, this is something we've been wanting to have done for awhile. We all really appreciate it (and we all rejoiced when we saw this PR!) A couple nitpick-y things I commented on above but thought I would expand on. There's some usage of I noted on some comments I saw that may have meant to be deleted, but they also may be necessary, if they are let me know! Again, thank you 🙏 |
|
@s-christoff Thank you for the quick follow up! It would make sense to me to remove those commented out log entries. At this point they could easily be added back in, but since they are not being used they could also be checked with a debugger instead. I will remove them for now. I'll make the adjustments to use Thank you very much! |
|
Kind of went nuts and made all of the logging consistent. There are a few lingering fmt.Sprintfs in some tests but in the primary code everything should be consistent with hclog now! |
|
I had missed several others. Now everything (except for the one test) is using a normal hclog format, or is using hclog.Fmt to format strings. @s-christoff I hope this is alright, if its not I have not squashed my commits yet so I can revert any changes that you deem unnecessary. |
| @@ -1856,7 +1856,7 @@ func TestRaft_ProtocolVersion_Upgrade_2_3(t *testing.T) { | |||
| // Use the new ID-based API to add the server with its ID. | |||
| future := c.Leader().AddVoter(c1.rafts[0].localID, c1.rafts[0].localAddr, 0, 1*time.Second) | |||
| if err := future.Error(); err != nil { | |||
| c.FailNowf("[ERR] err: %v", err) | |||
| c.FailNowf("err: %v", err) | |||
There was a problem hiding this comment.
Are these test changed accidental? They’re kinda useful for gripping test output
There was a problem hiding this comment.
They are intentional. The hclog library should include the log level in the entry every time anyway; and c.FailNowf is just a wrapper around an hclog call now. So it will include ERR or ERROR in square brackets for those entries.
|
🤦♀️ Hit the wrong button, sorry |
This simply replaces the existing logging implementation with hclog to
make everything consistent throughout the library.