Conversation
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
QixiaLu
changed the title
sreallymatt
left a comment
sreallymatt
left a comment
There was a problem hiding this comment.
Hi @QixiaLu, adding and using a preview version for an enum addition is not something we want to do.
We also have some concerns with what you mentioned in the description:
However, the latest stable API version is still work in progress which contains lots of breaking changes
Presumably the new stable API is being based on the work done for the preview API, which would indicate the preview may contain similar breaking changes?
We've tested and confirmed that the stable API currently used does accept 17 as input for the version, and this is being added manually (as an exception, not something we want to do frequently) in hashicorp/terraform-provider-azurerm#30683
Based on this, I'm going to close out this PR.
|
Hi @sreallymatt , thank you so much for reviewing it and finding the alternative solution! It would be the best if the current stable version supports v17 provision. We are also on the same page with you that it's a bit anti-commonsense to switch preview API for a single enum value change. That's why there are lots of back-and-forth confirmations with the service team internally to make sure it's intentional and no breaking change is introduced. I'll double check with the service team if there's any concern with this approach. To clarify this sentence, the latest stable API is based on
|
2 participants
2025-01-01-preview API specs: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/postgresql/resource-manager/Microsoft.DBforPostgreSQL/preview/2025-01-01-preview
There's a strong feature request for PostgreSQL 17 from the community. However, the latest stable API version is still work in progress which contains lots of breaking changes, and the release has been delayed for several times.
As an interim, to unblock us, we'll use 2025-01-01-preview to support v17. The service team has confirmed that if we migrate completely from the stable API to the preview one, all existing features will continue to function as expected. And the Preview API will provide production-level quality. I have already done local tests to make sure there's no breaking change.