Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator-go-sdk: allow configurable deletion of existing resources within an API version prior to generation, and enable for Microsoft Graph #4449

Merged

Conversation

manicminer
Copy link
Contributor

No description provided.

@manicminer manicminer added enhancement New feature or request tool/generator-go-sdk Issues with the Go SDK Generator labels Sep 25, 2024
@manicminer manicminer requested a review from a team September 25, 2024 17:31
…ithin an API version prior to generation, and enable for Microsoft Graph
@manicminer manicminer force-pushed the generator-go-sdk/optionally-delete-definitions-for-version branch from 99aff5e to 3b6a655 Compare September 25, 2024 17:32
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from 1 comment ♻️

"strings"

"github.com/hashicorp/pandora/tools/data-api-sdk/v1/models"
)

func CleanAndRecreateWorkingDirectory(path string) error {
// rm -r 💥
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be an emoji ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, it is a cautionary comment 🧨

@manicminer manicminer merged commit e8ce64f into main Sep 26, 2024
4 checks passed
@manicminer manicminer deleted the generator-go-sdk/optionally-delete-definitions-for-version branch September 26, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tool/generator-go-sdk Issues with the Go SDK Generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants