Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data: Rest Api Specs - regenerating based on dd214c29e7dbc3398c842b36f213979d869005aa #4426

Conversation

hc-github-team-tf-azure
Copy link
Collaborator

This PR is automatically generated based on the commit dd214c2

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes appear to be benign for Resource Manager SDK generation as currently configured. Notable changes include:

  • The ExampleValue for Resource IDs is now threaded through to/from the Data API, so this is being set to its zero value. However, in the only place this is being applied to the SDK, there's a get-out that continues to set the default value if it's empty in the definitions.

  • The Description for Models is now also being threaded to/from the Data API, and the Resource Manager importer is applying descriptions to its models. However the SDK Generator for Resource Manager is currently set to not emit comments for models. This could be turned on for prettiness (but also mega diff in the SDK).

  • Other model metadata like Nullable, ReferenceNameIsCommonType and IsParent (all bools) are being set to their null/zero values. These are opt-in and there is no corresponding behavior change.

@manicminer manicminer merged commit 13dca98 into main Sep 20, 2024
2 of 3 checks passed
@manicminer manicminer deleted the data/regeneration-from-dd214c29e7dbc3398c842b36f213979d869005aa-rest-api-specs branch September 20, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants