Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/importer-rest-api-specs - fix possible const conflict #4386

Closed
wants to merge 2 commits into from

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Sep 2, 2024

resolve issue in PR #4374
fix the issue that strings.EquelFold will randomly choose from capitalized or lowercased models, thus leads to conflicts in Enums, the details are in #4374 (comment)
By my local test, we can use exact match here without breaking existing generated data.

@teowa teowa changed the title tools/importer-rest-api-specs - using exact match for findTopLevelObject tools/importer-rest-api-specs - fix possible const conflict Sep 5, 2024
@teowa
Copy link
Contributor Author

teowa commented Sep 5, 2024

remove findAndMergeLocalMixins in first time parsing specs, by test this can avoid generate two provisioningState consts after flatten. For existing data, this won't break any thing, and it should save some time.
https://github.com/hashicorp/pandora/blob/22811ab2048bd6af4af2814f0d462b9f60eff809/tools/importer-rest-api-specs/components/parser/flattener.go#L30-46

@teowa teowa closed this Sep 12, 2024
@teowa
Copy link
Contributor Author

teowa commented Sep 12, 2024

superseded by #4411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant