tools/data-api: refactoring to use the new Data API SDK [Phase 2]
#3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've run a full generation which runs clean with these changes: |
tombuildsstuff
force-pushed
the
refactor/2-data-api
branch
from
6399d4f
to
033c266
Compare
tombuildsstuff
force-pushed
the
refactor/2-data-api
branch
from
033c266
to
9028fdf
Compare
tombuildsstuff
changed the title
tools/data-api: refactoring to use the new Data API SDKtools/data-api: refactoring to use the new Data API SDK [Phase 2]
tombuildsstuff
changed the base branch from
main
to
refactor/1-duplicating-models
This includes aliases for some of the more popular types - and also helpers specifically for the different types of Resource ID Segments (since these are widely used across the codebase).
tombuildsstuff
force-pushed
the
refactor/2-data-api
branch
from
9028fdf
to
ee40de5
Compare
tombuildsstuff
commented
Feb 15, 2024
| @@ -36,3 +39,5 @@ require ( | |||
| ) | |||
|
|
|||
| replace github.com/hashicorp/pandora/tools/sdk => ../sdk | |||
There was a problem hiding this comment.
note this is still used since testhelpers (and config need somewhere else to live, but that's a cross-project thing)
Breaking ChangesNo Breaking Changes were found 👍 |
Summary of ChangesNo Breaking or Non-Breaking Changes were found 👍 |
New Resource ID Segments containing Static IdentifiersNo new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙. |
catriona-m
approved these changes
Feb 15, 2024
tools/data-api/internal/endpoints/v1/transforms/sdk_operation_options.go
Show resolved
Hide resolved
tools/data-api/internal/endpoints/v1/transforms/terraform_resource_definition.go
Outdated
Show resolved
Hide resolved
Breaking ChangesNo Breaking Changes were found 👍 |
Summary of ChangesNo Breaking or Non-Breaking Changes were found 👍 |
New Resource ID Segments containing Static IdentifiersNo new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #3784
This PR implements Phase 2 of #3754 by switching
./tools/data-apiover to using the new Data API SDK.