Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes checksum for dependencies for Go 1.11.4+ #7261

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

davividal
Copy link
Contributor

Closes #7242

Quoting golang/go#29278 (comment):

Yes, pre-1.11.4, modules containing symlinks were constructed erroneously. 1.11.4 correctly omits those symlinks, which may change the sums for a few (hopefully isolated) modules.

@davividal davividal requested a review from a team as a code owner February 1, 2019 11:40
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 1, 2019

CLA assistant check
All committers have signed the CLA.

@davividal
Copy link
Contributor Author

I tested this PR agains Go 1.11.5.

@azr
Copy link
Contributor

azr commented Feb 1, 2019

Hey there @davividal, thanks for taking the time to do this. I need to double check a something still looks odd.

❯ go version
go version go1.11.5 darwin/amd64
❯ rm -rf ~/go/pkg/mod/cache
❯ GO111MODULE=on go mod download
...
go: finding github.com/oklog/run v1.0.0
go: verifying github.com/gotestyourself/[email protected]+incompatible: checksum mismatch
        downloaded: h1:AQwinXlbQR2HvPjQZOmDhRqsv5mZf+Jb1RnSLxcqZcI=
        go.sum:     h1:1yOKgt0XYKUg1HOKunGOSt2ocU4bxLCjmIHt0vRtVHM=
...

Edit: will try to fix it, oh dear, these downloads take forever !

@azr azr merged commit 25f51b9 into hashicorp:master Feb 1, 2019
@azr
Copy link
Contributor

azr commented Feb 1, 2019

All good, thanks !!!! 🙂

@davividal davividal deleted the fixes-checksum-1.11.4 branch February 2, 2019 13:17
@SwampDragons SwampDragons added this to the 1.3.5 milestone Feb 15, 2019
@SwampDragons SwampDragons added the build Relating to aspects of compilation or continuous integration label Feb 15, 2019
@chhaj5236
Copy link
Collaborator

@davividal @azr I encounter same issue here with current master branch.

➜ packer git:(master) ✗ go version
go version go1.11.5 darwin/amd64

➜ packer git:(master) ✗ uname -a
...Darwin Kernel Version 17.7.0...

And it prints following errors:

go: verifying github.com/docker/[email protected]: checksum mismatch
        downloaded: h1:V/WghsgVPZl+92drOvPEwuZdHskJmrnD83V1msaV/Jc=
        go.sum:     h1:DwY2bFs8p+xf2WaQewx2hnGdjYR5K4UAaxcNPyKkTek=

It seems caused by change in #7261
image

@azr
Copy link
Contributor

azr commented Feb 22, 2019

Yes, currently go modules and go vendors have a bit diverged. #7270 should sort this out.

@chhaj5236
Copy link
Collaborator

@azr I'm little confused here. Since I ran make dev in two different computers. One said checksum mismatch where I posted above. But another one which I tried tonight seemed working properly with the updated checksum h1:DwY2bFs8p+xf2WaQewx2hnGdjYR5K4UAaxcNPyKkTek=. Why the same code behaved differently in two environments.

@azr
Copy link
Contributor

azr commented Feb 22, 2019

go modules are still considered experimental, it could be that checksums are different between GOOSes kubernetes/kubernetes#69040, more: golang/go#27925

@chhaj5236
Copy link
Collaborator

@azr Thanks for the info. That is helpful.

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Relating to aspects of compilation or continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New setup checksum mismatch
5 participants