[HPR-1261] Add docker full image #12532
Conversation
There was a problem hiding this comment.
This looks good to me I added a commit to add the docs for the full version e25a24f. Please take a look over them and adjust as you see fit.
I know the docker build action handles the building of the containers so it is not needed but I do wonder if we should update the Makefile for the Packer project to include a target for the release-full target?
Maybe we should at least bump the version of Packer within the Makefile if we don't choose to add a target for the release-full
nywilken
added
backport/1.9.x
lbajolet-hashicorp
force-pushed
the
add_docker_full_image
branch
from
e25a24f to
9239a41
Compare
lbajolet-hashicorp
force-pushed
the
add_docker_full_image
branch
2 times, most recently
from
9755e54 to
3864d8d
Compare
There was a problem hiding this comment.
The changes to the build pipeline, Dockerfile, and Makefile look good to me. But the Docker README which gets published to DockerHub needs to be updated.
Can you please update to reflect the changes to the product Docker images.
|
Good call, I didn't know about this one, I'll update it this morning |
Since the main branch is not called master anymore, and the anchor was renamed, we fix both these changes in the link to that page from the README.
In addition to the `release-light' target, we add a `release_full' target to the Dockerfile, so that we can ship an image of Packer with the official plugins pre-bundled in their latest version.
The Docker images release-light and release-full are not to be built locally from a dev build, but from a release, and the commands to build those images are only referenced in CI, so we don't need to ship them as part of the makefile. In addition, those images are not straightforward to build from the Makefile, as they require quite a few things from the environment, as well as the binary installed in a specific location, which is never setup by the rest of the Makefile. Therefore, we opted to simplify the Makefile so that it only builds docker-dev for local use.
lbajolet-hashicorp
force-pushed
the
add_docker_full_image
branch
2 times, most recently
from
1679998 to
636215c
Compare
lbajolet-hashicorp
force-pushed
the
add_docker_full_image
branch
from
636215c to
19b5bf8
Compare
lbajolet-hashicorp
force-pushed
the
add_docker_full_image
branch
from
19b5bf8 to
04424f8
Compare
|
Perfect thanks, I just integrated your suggestions, unless you have an objection, I say we merge this when tests are green, sounds good to you @nywilken ? |
|
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Part of the bundled plugin removal effort, this PR adds a new Docker target: release-full.
This image includes Packer, and all the official plugins pre-installed in its environment.