packer: add HCL2 support for telemetry #12319
Conversation
lbajolet-hashicorp
force-pushed
the
telemetry_hcl2
branch
2 times, most recently
from
4d70d36 to
98af4ea
Compare
lbajolet-hashicorp
force-pushed
the
telemetry_hcl2
branch
from
98af4ea to
2c6f175
Compare
| @@ -120,9 +120,11 @@ func (m *Meta) GetConfig(cla *MetaArgs) (packer.Handler, int) { | |||
|
|
|||
| switch cfgType { | |||
| case ConfigTypeHCL2: | |||
| packer.CheckpointReporter.SetTemplateType(packer.HCL2Template) | |||
| @@ -489,6 +497,8 @@ func (cfg *PackerConfig) getCoreBuildProvisioner(source SourceUseBlock, pb *Prov | |||
| return packer.CoreBuildProvisioner{}, diags | |||
| } | |||
|
|
|||
| flatProvisionerCfg, _ := decodeHCL2Spec(pb.HCL2Ref.Rest, ectx, provisioner) | |||
There was a problem hiding this comment.
Lets move this initialization closer to where it is used which right about line 521.
That said, do we want to capture details about the provisioner being wrapped?
There was a problem hiding this comment.
You can disregard the question above about including the rapped provisioner info. The configuration should already contain details about the wrapped provisioner so the flattened config will already have all the information, correct?
There was a problem hiding this comment.
Theoretically it should yes! I'll test it to be sure though
Packer's telemetry package captures the field names from a configuration on legacy JSON templates, but did not contain any code for handling HCL2 template configurations. This commit adds a routine to extract the field names from a HCL2 configuration once flattened, and adds some glue code to propagate the configurations to the telemetry structures.
lbajolet-hashicorp
force-pushed
the
telemetry_hcl2
branch
from
2c6f175 to
6b6269b
Compare
nywilken
added
enhancement
hcl2
backport/1.8.x
The template type for a builder, provisioner, post-processor or datasource was not tracked with telemetry data. This commit adds the infrastructure to track this, bumping the schema for non-crashes to `beta/packer/6' at the same time.
lbajolet-hashicorp
force-pushed
the
telemetry_hcl2
branch
from
6b6269b to
e7dbd4d
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Packer's telemetry package captures the field names from a configuration on legacy JSON templates, but did not contain any code for handling HCL2 template configurations.
This commit adds a routine to extract the field names from a HCL2 configuration once flattened, and adds some glue code to propagate the configurations to the telemetry structures.