Send channel id to HCP Packer #11861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylviamoss
force-pushed
the
hcp_packer_source_channel_id
branch
from
7281f31 to
f2b8a39
Compare
sylviamoss
force-pushed
the
hcp_packer_source_channel_id
branch
from
ef5d2d1 to
38b0b2c
Compare
sylviamoss
changed the title
nywilken
reviewed
Jul 27, 2022
sylviamoss
force-pushed
the
hcp_packer_source_channel_id
branch
from
867c962 to
6ebbab9
Compare
|
@nywilken I addressed all of your comments! 🎉 |
sylviamoss
force-pushed
the
hcp_packer_source_channel_id
branch
from
331d22f to
7f91685
Compare
lbajolet-hashicorp
approved these changes
Jul 28, 2022
| @@ -99,7 +98,7 @@ func (d *Datasource) Configure(raws ...interface{}) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // Information from []*models.HashicorpCloudPackerImage with some information | |||
| // DatasourceOutput Information from []*models.HashicorpCloudPackerImage with some information | |||
There was a problem hiding this comment.
I'm guessing this was added to make the linters happy?
Co-authored-by: Wilken Rivera <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HCP Packer needs to track the channel that was queried to get the source image. This PR adds the required changes to start sending the information to the service.
These changes conflict with #11905