-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add pause_after config to powershell provisioner like shell #11792
feat: Add pause_after config to powershell provisioner like shell #11792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @teddylear,
The code looks good to me as it stands, thanks for the contribution!
There seems to be a small issue with the pipeline, but it shouldn't be a problem, we'll merge this soon.
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my first review was made before I had run make ci-lint
and make fmt-check
locally, sorry for this.
Both steps have pointed out some suggestions that I have summarized in my latest review, if you can address those we can merge this.
Not that normally these are run by the CI pipeline, for some reason these have not been triggered on your PR.
If you modify the code further, could you consider running both make ci-lint
and make fmt-check
so the code is in an optimal state and primed to be merged?
Thanks and sorry for forgetting to check these in my previous review!
@lbajolet-hashicorp Thanks for the review! I updated code to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest changes, all checks pass; LGTM!
Thanks for the contribution again @teddylear, much appreciated
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
feat: Add
pause_after
config to powershell provisioner like shellAdded a simple test to make sure that duration of Provision is longer than
pause_after
setting.Closes #10887