Skip to content

Partifact source #11304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2021
Merged

Partifact source #11304

merged 5 commits into from
Oct 4, 2021

Conversation

SwampDragons
Copy link
Contributor

DELETE THIS TEMPLATE BEFORE SUBMITTING

This PR updates the HCP sdk to use the regenerated sdk name. It looks like a bigger change than it is.

It also updates the packer plugin sdk, allowing us to set the "source" field on the PARtifact. This will enable the HCP Packer registry to track image ancestry.

@SwampDragons SwampDragons requested a review from a team as a code owner October 4, 2021 18:43
@nywilken
Copy link
Contributor

nywilken commented Oct 4, 2021

Is the new generated names because of a change we made to the API? Or is it is a sagger thing? For the future we might want to consider using versions for the API. Tests are failing because we have to update the mock service as well

func (svc *MockPackerClientService) CreateBucket(params *packerSvc.CreateBucketParams, _ runtime.ClientAuthInfoWriter) (*packerSvc.CreateBucketOK, error) {

That said the changes look good.

@SwampDragons
Copy link
Contributor Author

Fixed the mock. This was a swagger update that changed the SDK. The http underlying the SDK didn't change, but yes -- this was a one-time change that should never happen again.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwampDragons SwampDragons merged commit 12a8971 into master Oct 4, 2021
@SwampDragons SwampDragons deleted the partifact_source branch October 4, 2021 21:38
@nywilken nywilken added this to the 1.7.7 milestone Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Nov 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants