-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Partifact source #11304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partifact source #11304
Conversation
Is the new generated names because of a change we made to the API? Or is it is a sagger thing? For the future we might want to consider using versions for the API. Tests are failing because we have to update the mock service as well packer/internal/registry/mock_service.go Line 67 in 11f5da8
That said the changes look good. |
Fixed the mock. This was a swagger update that changed the SDK. The http underlying the SDK didn't change, but yes -- this was a one-time change that should never happen again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
DELETE THIS TEMPLATE BEFORE SUBMITTING
This PR updates the HCP sdk to use the regenerated sdk name. It looks like a bigger change than it is.
It also updates the packer plugin sdk, allowing us to set the "source" field on the PARtifact. This will enable the HCP Packer registry to track image ancestry.