Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update gomod go version #9119

Merged
merged 1 commit into from
Oct 19, 2020
Merged

build: update gomod go version #9119

merged 1 commit into from
Oct 19, 2020

Conversation

shoenig
Copy link
Contributor

@shoenig shoenig commented Oct 17, 2020

Keep go.mod go version up to date with the version of Go used
to build Nomad.

@shoenig
build: update gomod go version
dbf1390 
Keep go.mod go version up to date with the version of Go used
to build Nomad.
@shoenig shoenig requested review from tgross and notnoop October 17, 2020 14:43
tgross
tgross approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

notnoop
notnoop approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the issue requiring us to vendor dependencies still relevant with new go version? Don't recall the context well.

@tgross
Copy link
Member

tgross commented Oct 19, 2020 •
edited
Loading

We should probably update https://github.com/hashicorp/nomad/blob/master/tools/go.mod#L3 as well. Done in #9125

@shoenig shoenig merged commit cf9a86f into master Oct 19, 2020
@shoenig shoenig deleted the f-update-gomod-1.15 branch October 19, 2020 19:36
@shoenig
Copy link
Contributor Author

shoenig commented Oct 19, 2020

@notnoop if you're referring to the need to vendor the api submodule, that's a "feature" starting with go1.14 golang/go#33789

Otherwise, we're still vendoring dependencies until the artifactory computes checksums correctly (AFAIK)

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notnoop notnoop notnoop approved these changes

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoenig @tgross @notnoop