Stack uses computed node class to minimize number of feasibility checks #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case strings.HasPrefix(target, "$node.unique."): | ||
| return true | ||
|
|
||
| case strings.HasPrefix(target, "$attr."): |
There was a problem hiding this comment.
Can we simplify this to just HasPrefix("$attr.unique.") to avoid the double prefix + double trim
|
Left some comments, LGTM |
dadgar
force-pushed
the
f-feasibility-node-classes
branch
from
70dfa1a to
97070f4
Compare
dadgar
added a commit
that referenced
this pull request
Jan 27, 2016
Stack uses computed node class to minimize number of feasibility checks
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack uses computed node class to minimize number of feasibility checks