e2e: Ensure Consul client is running before starting Nomad service.#24964
e2e: Ensure Consul client is running before starting Nomad service.#24964
Conversation
tgross
left a comment
There was a problem hiding this comment.
It looks like as of hashicorp/consul#16845 Consul supports systemd Type=notify and that's actually now part of their packaged unit file: https://github.com/hashicorp/consul/blob/main/.release/linux/package/usr/lib/systemd/system/consul.service#L9 We're not using that unit file (for reasons which were probably good at the time but may not make sense anymore). That should allow depends/wants to work correctly.
77a79fc to
727f931
Compare
This was allowing Nomad to start up before Consul. See hashicorp/nomad#24964
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
The recent change of the Consul fingerprinter means Consul must be up and started before the Nomad client, otherwise the Nomad process needs to be sent a SIGHUP.
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.